boyan_k/temmies
boyan_k/temmies
1
0
Fork 0
mirror of https://github.com/Code-For-Groningen/temmies.git synced 2025-03-15 07:10:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Rewrote login, fixed timing bug

Browse Source
This commit is contained in:
Boyan 2025-03-01 17:48:19 +01:00
parent 0ed744dff8
commit c9a2e1f456
1 changed files with 37 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
temmies/themis.py
View File

@ -4,6 +4,10 @@ Main class for the Themis API using the new JSON endpoints.
from requests import Session from requests import Session
from selenium import webdriver from selenium import webdriver
from selenium.webdriver.support.ui import WebDriverWait
from selenium.webdriver.support import expected_conditions as EC
from selenium.common.exceptions import TimeoutException
from selenium.webdriver.common.by import By from selenium.webdriver.common.by import By
from selenium.common.exceptions import NoSuchElementException, StaleElementReferenceException from selenium.common.exceptions import NoSuchElementException, StaleElementReferenceException
from json import dumps from json import dumps
@ -90,43 +94,47 @@ class Themis:
def login(self, session: Session) -> Session: def login(self, session: Session) -> Session:
""" """
Login to Themis by spawning a selenium browser, logging in and storing the session. Login to Themis by spawning a selenium browser
""" """
login_url = f"{self.base_url}/login" login_url = f"{self.base_url}/login"
# Start a full browser to login
driver = webdriver.Chrome() driver = webdriver.Chrome()
driver.get(login_url) driver.get(login_url)
while True: wait = WebDriverWait(driver, 60)
if driver.find_elements(By.TAG_NAME, "pre"):
break
try: try:
# if any of the fields are already filled, don't fill them wait.until(EC.url_contains("signon.rug.nl/nidp/saml2/sso"))
if (passw := driver.find_element(By.NAME, "Ecom_Password")) and not passw.get_attribute("value") and self.password: current_url = driver.current_url
passw.send_keys(self.password)
if (user := driver.find_element(By.NAME, "Ecom_User_ID")) and not user.get_attribute("value") and self.user:
user.send_keys(self.user)
except NoSuchElementException: # If on the sign-on page fill in the credentials
pass if "signon.rug.nl/nidp/saml2/sso" in current_url:
user_field = wait.until(EC.presence_of_element_located((By.NAME, "Ecom_User_ID")))
pass_field = wait.until(EC.presence_of_element_located((By.NAME, "Ecom_Password")))
except StaleElementReferenceException: if self.user and not user_field.get_attribute("value"):
pass user_field.clear()
user_field.send_keys(self.user)
if self.password and not pass_field.get_attribute("value"):
pass_field.clear()
pass_field.send_keys(self.password)
# destroy the password from memory (security) # THIS IS LIKELY TO BREAK AT SOME POINT
self.password = "I-HAVE-BEEN-REMOVED" wait.until(EC.text_to_be_present_in_element((By.TAG_NAME, "body"), "Cannot GET"))
# export all stored cookies except TimeoutException:
cookies = driver.get_cookies() print("Timeout waiting for login/2FA page to load.")
driver.quit() except (NoSuchElementException, StaleElementReferenceException) as e:
print(f"Encountered an error: {e}")
finally:
# security
self.password = "I-HAVE-BEEN-REMOVED"
cookies = driver.get_cookies()
driver.quit()
# add all cookies to the session # Add all cookies to the session.
for cookie in cookies: for cookie in cookies:
session.cookies.set(cookie["name"], cookie["value"]) session.cookies.set(name=cookie["name"], value=cookie["value"])
return session return session